Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize font usage #978

Merged
merged 11 commits into from
May 30, 2024

Conversation

dennyscode
Copy link
Contributor

Ticket: https://lifi.atlassian.net/browse/LF-8034

Still making use of inter-var to keep the same font styles as we used to have.

Now:
image

Before:
image

@dennyscode
Copy link
Contributor Author

I´d prefer to not use our inter-var file to reduce the loaded fonts even more. That way, we´d only use the Inter font provided by Google fonts. That state can be found in the following commit "chore: improve font usage" which we could revert: d1e5079

image

It comes with the problem that it won´t match the font we used to have:
font-optimization-screen-capture.webm

@oktapodia
Copy link
Member

It seems that the default font-size is different + letter-spacing css rule, we should be able to match it

@tcheee tcheee added the wip Work in Progress label May 22, 2024
@dennyscode dennyscode added the feature This label will create a dedicated Feature environment label May 22, 2024
Copy link

Hey! Those are your new endpoints: https://feat-lf8034jumperremovethefont.jumper.exchange

Copy link
Contributor

@tcheee tcheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tcheee tcheee merged commit 39700f6 into develop May 30, 2024
1 check passed
@tcheee tcheee deleted the LF-8034-jumper-remove-the-fonts-from-the-loading branch May 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This label will create a dedicated Feature environment wip Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants