-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes SEO plugin (widget) #21780
base: 5.x-dev
Are you sure you want to change the base?
Removes SEO plugin (widget) #21780
Conversation
As this is a breaking change, can we add the changelog entry? Wondering actually if we should keep the plugin itself and keep the API returning an empty datatable and only remove the widget so we're not breaking the HTTP API? In Matomo 6 we could then break the API and remove the entire plugin. |
@tsteur please discuss this with @mattab. The target was to remove this feature with lowest effort. |
@sgiehl I think the issue was maybe to remove the widget, not the plugin?
I'd say it was about the lowest effort while still keeping our promises such as that we won't break our APIs. It could be even fine to only remove the Widget file itself and the rest in Matomo 6. This way it would have been very little effort to just remove the widget file without breaking the HTTP API etc.
It's overall fine to remove it as it provides very little value nowadays. Breaking the API can be an issue. For example the Matomo Connect WordPress plugin uses the API in https://github.com/braekling/WP-Matomo/blob/master/classes/WP_Piwik/Widget/Seo.php#L14 etc. |
In that case, we will move removing that plugin to Matomo 6. If it is causing problems on Cloud we can simply disable the plugin there. On premise it was working as expected anyway. |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
Description:
Matomo was providing a SEO widget, which allowed to fetch some stats around indexed pages on e.g. Google, Bing or Alexa. This widget failed to fetch its stats (on cloud) more and more, making the widget mostly useless.
Also when it comes to “SEO” in a dashboard, this widget under-delivers on what people would hope to see. We therefore decided to remove the widget.
If anyone would like to keep the widget please create an issue for that, and we might consider releasing it as a separate plugin instead.
refs #21712
Review