Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ak/feat/create certificates #65

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Abhinav0909
Copy link

#15 Fix all the bugs in ui

…wind config to new tailwind config and set some eslint rules to avoid warnings.
…wind config to new tailwind config and set some eslint rules to avoid warnings.
@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/megabyte-143/certified-cliche/7phdfzrgPG5qVwMkxUak7TVNGGsZ
✅ Preview: https://certified-cliche-git-fork-abhinav0909-ak-fe-07ba21-megabyte-143.vercel.app

@raysummee
Copy link
Collaborator

@Abhinav0909 please edit the PR to dev from main

@Abhinav0909
Copy link
Author

I have done that haven't i

@raysummee
Copy link
Collaborator

raysummee commented Mar 9, 2022

@Abhinav0909

image

  • Click the edit button there on this PR
  • After that there will be a drop down as base: main. Click on it and select dev
  • Save

@Abhinav0909 Abhinav0909 changed the base branch from main to dev March 9, 2022 12:34
@Abhinav0909
Copy link
Author

done

@raysummee
Copy link
Collaborator

@Abhinav0909

  • You have misplaced the select event and event name input.

What you have done:

image

Should be this:

image

  • Edit button are not aligned and not matching the design icon

image

  • When the window width is decrease, the image are gone (not responsive on smaller desktop):

image

  • Decrease the margin too: Check the design

image

@Abhinav0909
Copy link
Author

can we have a meet at discord.I have some doubts that I have to ask

@raysummee
Copy link
Collaborator

@Abhinav0909 ping your preferred time in the discord channel.

@raysummee
Copy link
Collaborator

@Abhinav0909 are you around? If you still having the doubt feel free to ping me in the discord channel.

@Abhinav0909
Copy link
Author

Can you come at 10 pm at discord?

@raysummee
Copy link
Collaborator

@Abhinav0909 Sorry for the late reply. If you still have doubt, let's have a meeting today through discord. You can also ping the # general channel on discord

@megabyte0x
Copy link
Owner

Hey @Abhinav0909, any updates on this?

@megabyte0x megabyte0x linked an issue Mar 23, 2022 that may be closed by this pull request
@megabyte0x megabyte0x added GSSoC22 Girl Script Summer of Code 2022 2-Days Submission in 2 Days labels Mar 23, 2022
@raysummee
Copy link
Collaborator

@Abhinav0909 Good work. I can see some fixes as suggested. But you missed some. Those are -

image

  • Not of same width

image

  • Not center align in different screen size

image

  • Too much margin on the container

@megabyte0x
Copy link
Owner

@Abhinav0909 any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Days Submission in 2 Days GSSoC22 Girl Script Summer of Code 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page - Create certificate
3 participants