Force exhaustive search when faceting is requested #3453
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Related to #3426.
What does this PR do?
When not using pagination mode, the search is not exhaustive. This can result in incomplete results for facet distribution and wrong results for facet stats (as implemented in #3423).
This PR forces the search to be as exhaustive as possible1, even when not using pagination mode, as soon as a facet distribution (or facet stats) is required.
Tests
Unfortunately, I was not able to come up with a test case that demonstrates how the search is not exhaustive by default. I'm still opening the PR should the issue pop up.
Footnotes
My understanding is that we can still have differences in distribution/stats when distinct attributes are used in the query. ↩