-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the System_Boundary stereotype #5243
base: develop
Are you sure you want to change the base?
Correct the System_Boundary stereotype #5243
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5243 +/- ##
=======================================
Coverage 5.73% 5.73%
=======================================
Files 278 278
Lines 41999 41999
Branches 490 490
=======================================
Hits 2409 2409
Misses 39590 39590
Flags with carried forward coverage won't be shown. Click here to find out more. |
@mermaid-js/atlantians can someone familiar with C4 review? |
@mermaid-js/atlantians this should be a quick-win review for someone with a minute to spare please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mermaid-js/atlantians can someone familiar with C4 review?
I haven't worked on the C4 Diagram, but this fixes the example case in docs to have a system boundary labelled correctly on BankBoundary2
. Earlier it was labelled as enterprise boundary.
I haven't worked with C4 either, but this seems to be an obvious fix |
📑 Summary
Trivial change to correct the
[ENTERPRISE]
stereotype label to[SYSTEM]
for C4 System_Boundary.