-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4060 gantt working hours #5403
base: develop
Are you sure you want to change the base?
Feature/4060 gantt working hours #5403
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sidharthv96 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5403 +/- ##
==========================================
+ Coverage 5.73% 5.86% +0.13%
==========================================
Files 277 278 +1
Lines 42001 42084 +83
Branches 515 499 -16
==========================================
+ Hits 2407 2468 +61
- Misses 39594 39616 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
You can assign core working hours within the Gantt by providing a time value to `wdStartTime` and `wdEndTime`. It expects a time in the 24hour format as shown below. | ||
|
||
```gantt | ||
title A Gantt Diagram | ||
accTitle: A simple sample gantt diagram | ||
accDescr: 2 sections with 2 tasks each, from 2014 | ||
dateFormat YYYY-MM-DD | ||
wdStartTime 08:00 | ||
wdEndTime 17:00 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the YAML config for this, instead of adding more custom syntax?
You can assign core working hours within the Gantt by providing a time value to `wdStartTime` and `wdEndTime`. It expects a time in the 24hour format as shown below. | |
```gantt | |
title A Gantt Diagram | |
accTitle: A simple sample gantt diagram | |
accDescr: 2 sections with 2 tasks each, from 2014 | |
dateFormat YYYY-MM-DD | |
wdStartTime 08:00 | |
wdEndTime 17:00 | |
``` | |
You can assign core working hours within the Gantt by providing a time value to `wdStartTime` and `wdEndTime`. It expects a time in the 24hour format as shown below. | |
``` | |
--- | |
title: A Gantt Diagram | |
config: | |
gantt: | |
dateFormat: YYYY-MM-DD | |
workdayStartTime: 08:00 | |
workdayEndTime: 17:00 | |
--- | |
gantt | |
accTitle: A simple sample gantt diagram | |
accDescr: 2 sections with 2 tasks each, from 2014 | |
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry can you explain in a bit more detail what you mean? Does this relate to not using jison?
📑 Summary
First contribution to the community but a long time user and want to start providing some added benefit. Only a hobbyist developer so apologies in advance if some of this is not right first time.
Updated the Gantt chart to allow workday start and end times to be entered and for the gantt chart to then uses them for calculated task end dates assuming durations in hours and or minutes are provided.
Resolves #4060
📏 Design Decisions
Added options to the parser for a Working day start time and working day end time
Ammended the GetEndDate function to be able to calculate task end dates and times using working hours if provided by the user alongside a task duration. Ensured through testing that other elements of the gantt chart functionality such as inclusive / exclusive weekends can still be used in conjuction
Added applicable tests for both the parser and the ganttDB file.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch