-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy annotation text in HTML report #30749
base: main
Are you sure you want to change the base?
Copy annotation text in HTML report #30749
Conversation
@amankagithub please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This comment has been minimized.
This comment has been minimized.
de107f1
to
fdd39c1
Compare
Test results for "tests 1"1 failed 2 flaky27028 passed, 610 skipped Merge workflow run. |
display: none; | ||
} | ||
|
||
.test-case-annotation:hover .annotation-copy-button{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like you would need this dance for every copy button application. Would it be possible to do something like this to encapsulate these styles:
<CopyToClipboardContainer description={description}>
<span className='annotation-copy-button'/>
</CopyToClipboardContainer>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every copy button , just for this annotation copy button . We want to display the copy button only when we hover over the text . Could you please help me with how your approach would help in this use case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CopyToClipboardContainer container would position the copy button after its children and make it visible upon hover.
return description; | ||
} | ||
|
||
function TestCaseAnnotationView({ annotation: { type, description } }: { annotation: TestCaseAnnotation }) { | ||
return ( | ||
<div className='test-case-annotation'> | ||
<span style={{ fontWeight: 'bold' }}>{type}</span> | ||
<span style={{ fontWeight: 'bold', display: 'inline-block', marginBlock: '3px' }}>{type}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display: 'inline-block' - what else would this span be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default span
will be inline
. I needed to add some margin to solve following problem
without-display-property.mp4
with-display-property.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping it would go away with the container approach.
Feature Request : #30141
In this PR I have added changes required to make annotation text be copied in one click .
Annotation
On hover
On copy