Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StableEditorBottomScrollState #212970

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix StableEditorBottomScrollState #212970

merged 1 commit into from
May 23, 2024

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented May 17, 2024

I think this fixes StableEditorBottomScrollState

But the problem is not completely solved because:

  • there is a call to revealRangeNearTopIfOutsideViewport somewhere in the view zone show code.
  • (when doing "explain this") - when markdown streams in, the view zone grows but nobody calls StableEditorBottomScrollState
  • (when doing "document this") - when edits stream in, I think the view zone grows and also there is a call to revealRangeInCenterIfOutsideViewport

I would continue by figuring out where the view zone changes its height and using StableEditorBottomScrollState there.

@alexdima alexdima self-assigned this May 17, 2024
@alexdima alexdima requested a review from jrieken May 17, 2024 14:20
@alexdima alexdima marked this pull request as ready for review May 17, 2024 14:24
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 17, 2024
@alexdima alexdima enabled auto-merge (squash) May 22, 2024 17:10
@alexdima alexdima merged commit ba6fb3b into main May 23, 2024
7 checks passed
@alexdima alexdima deleted the alexd/rapid-muskox branch May 23, 2024 06:50
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants