Partially enable typescript esModuleInterop for migrating towards ESM imports #213014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonSiefke just a quick heads-up that we have started #214144. This will replace this PR for which I wanna apologise but is also the whole thing (which we could coordinate within the team) which is very cool. Thanks a ton for kicking this off |
|
Closing in favor of #214144. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #212977
This PR somewhat enables typescript
esModuleInterop.Before fully enabling
esModuleInterop, it seems ~600 assert imports would need to be adjusted.While that's still a lot of changes, it could be done incrementally on a case by cases basis, making the many changes easier.