-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sufficient deadlines and countermeasures to handle hung node scenario #19688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
pause-container-test
branch
2 times, most recently
from
May 14, 2024 16:50
351b2af
to
5f9fec9
Compare
harshavardhana
force-pushed
the
pause-container-test
branch
4 times, most recently
from
May 14, 2024 22:20
118c7b2
to
3d473d9
Compare
krisis
approved these changes
May 14, 2024
harshavardhana
force-pushed
the
pause-container-test
branch
3 times, most recently
from
May 17, 2024 10:49
01aab05
to
23766c5
Compare
harshavardhana
approved these changes
May 17, 2024
harshavardhana
force-pushed
the
pause-container-test
branch
from
May 17, 2024 10:55
23766c5
to
6998367
Compare
harshavardhana
changed the title
Added a flow to test one node paused scenario
@harshavardhana Add sufficient deadlines and countermeasures to handle hung node scen… 6998367 …ario
May 17, 2024
harshavardhana
changed the title
@harshavardhana Add sufficient deadlines and countermeasures to handle hung node scen… 6998367 …ario
Add sufficient deadlines and countermeasures to handle hung node scenario
May 17, 2024
harshavardhana
force-pushed
the
pause-container-test
branch
4 times, most recently
from
May 17, 2024 18:05
12a1a10
to
80daf94
Compare
harshavardhana
force-pushed
the
pause-container-test
branch
2 times, most recently
from
May 19, 2024 15:59
08e342f
to
b6ced9c
Compare
vadmeste
approved these changes
May 20, 2024
klauspost
reviewed
May 20, 2024
harshavardhana
force-pushed
the
pause-container-test
branch
6 times, most recently
from
May 22, 2024 17:52
108baff
to
9351b13
Compare
…ario Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io> Signed-off-by: Harshavardhana <harsha@minio.io>
harshavardhana
force-pushed
the
pause-container-test
branch
2 times, most recently
from
May 22, 2024 19:52
6118150
to
6b3388d
Compare
harshavardhana
force-pushed
the
pause-container-test
branch
from
May 22, 2024 20:18
6b3388d
to
2192b53
Compare
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
May 29, 2024
since minio#19688 there was a regression introduced during drive lookups for single node multi-drive setups, drive replacement would not work correctly without this PR.
8 tasks
harshavardhana
added a commit
that referenced
this pull request
May 29, 2024
) since #19688 there was a regression introduced during drive lookups for single node multi-drive setups, drive replacement would not work correctly without this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Add sufficient deadlines and countermeasures to handle the hung node scenario
Motivation and Context
This PR tries to address the hung node scenario by adding sufficient
deadlines and counter measures for such an eventuality.
How to test this PR?
This PR already adds the relevant tests; you may reproduce them
locally as needed by following the mint automation piece.
Types of changes
Checklist:
commit-id
orPR #
here)