cohttp-eio: Improve error handling in example server #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
force-pushed
the
eio-fix-example
branch
2 times, most recently
from
034aba8
to
5c9b4dd
Compare
The example was using `~on_error:raise`, which causes the server to crash if any error occurs handling a connection. This is unlikely to be what you want. Instead, log the error and continue. This also now matches the behaviour of the Lwt example, which just logs errors and continues.
talex5
force-pushed
the
eio-fix-example
branch
from
852dc38
to
282c81e
Compare
mseri
approved these changes
Feb 27, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was using
~on_error:raise, which causes the server to crash if any error occurs handling a connection. This is unlikely to be what you want. Instead, log the error and continue.This also now matches the behaviour of the Lwt example, which just logs errors and continues.
(from #1021 (comment))