Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle files #977

Merged
merged 4 commits into from Apr 4, 2023
Merged

Fix handle files #977

merged 4 commits into from Apr 4, 2023

Conversation

mseri
Copy link
Collaborator

@mseri mseri commented Apr 4, 2023

Fixes #978

Reported by Stéphane Glondu, fixed by Thomas Gazagnaire (samhot)

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Fixed by Anurag Soni (anuragsoni)

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
The only way to avoid leaks is to always consume the stream, which
means also that the developer needs to ensure that infinite unclosable
streams are not produced.

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri mseri mentioned this pull request Apr 4, 2023
@mseri mseri merged commit 11c8f54 into mirage:master Apr 4, 2023
17 of 19 checks passed
@mseri mseri deleted the fix-handle-files branch April 4, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fd leak in handle_files
1 participant