Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #47731

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

racequite
Copy link
Contributor

- What I did

fix function names in comment

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland
Copy link
Contributor

vvoland commented Apr 19, 2024

Thanks!

We require all commit messages to have a Signed-off-by line with your actual name (not a pseudonym)
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

@vvoland vvoland added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Apr 19, 2024
client/client_test.go Outdated Show resolved Hide resolved
@coolljt0725 coolljt0725 added status/2-code-review and removed dco/no Automatically set by a bot when one of the commits lacks proper signature labels Apr 22, 2024
Signed-off-by: Rui JingAn <quiterace@gmail.com>
@racequite
Copy link
Contributor Author

Thanks!

We require all commit messages to have a Signed-off-by line with your actual name (not a pseudonym) and e-mail (see "Sign your work" in the CONTRIBUTING.md in this repository), which looks like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

Thanks! Modified

@racequite
Copy link
Contributor Author

If anything need I to do, Please feel free to tell me.

@coolljt0725
Copy link
Contributor

@racequite sorry for the delay. Looks we also have similar issues in https://github.com/moby/moby/blob/master/client/client_test.go like:

func TestNegotiateAPVersionOverride(t *testing.T) {

// TestNegotiateAPVersionConnectionFailure asserts that we do not modify the

func TestNegotiateAPVersionConnectionFailure(t *testing.T) {
,
In these places, the AP should be API
could you please have these fixed in this PR as well ?

@thaJeztah thaJeztah added this to the 27.0.0 milestone Jun 9, 2024
@thaJeztah
Copy link
Member

Let me bring this one in; I'll open a quick follow-up for those other ones 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 311c949 into moby:master Jun 9, 2024
126 checks passed
@thaJeztah
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants