-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Allow natural list.__repr__() syntax for List #2733
[stdlib] Allow natural list.__repr__() syntax for List #2733
Conversation
No need for the @staticmethod and the __type_of() trick in List.__repr__() Signed-off-by: Manuel Saelices <msaelices@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
!sync |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Landed in 131d8d4! Thank you for your contribution 🎉 |
…0304) [External] [stdlib] Allow natural list.__repr__() syntax for List No need for the `@staticmethod` and the `__type_of()` trick in `List.__repr__()` Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2733 MODULAR_ORIG_COMMIT_REV_ID: 50d64ae606e89dde9f0b5db575f472cf89fbfca5
…0304) [External] [stdlib] Allow natural list.__repr__() syntax for List No need for the `@staticmethod` and the `__type_of()` trick in `List.__repr__()` Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2733 MODULAR_ORIG_COMMIT_REV_ID: 50d64ae606e89dde9f0b5db575f472cf89fbfca5
…0304) [External] [stdlib] Allow natural list.__repr__() syntax for List No need for the `@staticmethod` and the `__type_of()` trick in `List.__repr__()` Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2733 MODULAR_ORIG_COMMIT_REV_ID: 50d64ae606e89dde9f0b5db575f472cf89fbfca5
No need for the
@staticmethod
and the__type_of()
trick inList.__repr__()