net: bring internal clarity and consistency between IPv4 and IPv6 #9279
Conversation
Modify all IPv4 variables, function arguments name and daemon arguments to IPv4 specific naming to raise consistency with IPv6. This change is done in order to make source code more legible before addressing monero-project#8818. * --p2p-bind-ip is replaced with --p2p-bind-ipv4-address * --p2p-bind-port is replaced with --p2p-bind-port-ipv4 * --rpc-bind-ip is replaced with --rpc-bind-ipv4-address * --rpc-restricted-bind-ip is replaced with --rpc-restricted-bind-ipv4-address Bug: monero-project#8818
* --p2p-bind-port-ipv4 is replaced with --p2p-bind-ipv4-port * --p2p-bind-port-ipv6 is replaced with --p2p-bind-ipv6-port
To ensure retro compatibility, legacy IPv4 daemon arguments and configuration settings changes are marked as deprecated, but can still be used falling back to new option name when new options are not used. Raise warning in case legacy option are used. * --p2p-bind-ip is an alias to --p2p-bind-ipv4-address * --p2p-bind-port is an alias to --p2p-bind-ipv4-port * --p2p-bind-port-ipv6 is an alias to --p2p-bind-ipv6-port * --rpc-bind-ip is an alias to --rpc-bind-ipv4-address * --rpc-restricted-bind-ip is an alias to --rpc-restricted-bind-ipv4-address
The change is made in order to raise consistency and legibility so that other changes made in this part of the code are easier to read for the developer. I've been preparing another PR (not published yet) making changes in this code part and I found myself in a lot of difficulty making such changes due to internal naming that is highly confusing and error prone. This PR will help future changes in the part of the code much easier to follow. This is long PR indeed, however I feel is a necessity to make this code more legible as we go. |
|
I think this something that we wouldn't accept historically, as it changes a lot of lines attributable to you, with minimal benefit. (I don't think the lack of |
| @@ -62,5 +62,5 @@ EXPOSE 18081 | |||
| USER monero | |||
|
|
|||
| ENTRYPOINT ["monerod"] | |||
| CMD ["--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"] | |||
There was a problem hiding this comment.
The change in runtime flags is an almost certain no, as this requires everyone change their run scripts for minimal benefit.
There was a problem hiding this comment.
4175d5b adds retro compatibility with such options
Modify all IPv4 variables, function arguments name and daemon arguments to IPv4 specific naming to raise consistency with IPv6. This change is done in order to make source code more legible before addressing #8818.
To ensure retro compatibility, daemon arguments and configuration settings changes are marked as deprecated, but can still be used falling back to new option name when new options are not used.
Bug: #8818