Don't override fork strategy at block import #2794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
RomarQ
approved these changes
May 2, 2024
Coverage Report@@ Coverage Diff @@
## master moonkit-not-override-fork-strategy-block-import +/- ##
==================================================================================
Coverage 73.06% 73.06% 0.00%
Files 228 228
Lines 69944 69944
==================================================================================
Hits 51103 51103
Misses 18841 18841
|
|
Replaced by #2806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Historically aura for parachain was overcharing fork strategy for parachain at block import, but it's no longer necessary.
This PR update our moonkit fork to remove the NimbusBlockImport type, a wrapper that impl
BlockImportonly to override the fork strategy.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?