Add multi-recipient transactions support #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract recipient form containing address and assets into a separate component. * Keep track of a list of recipients in SendView. * Extend P2P transaction building such that it takes a list of receivers instead of just a single one. * Successfully sent 2-recipient transaction.
|
This PR is no more compatible with the base branch, closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are likely some issues with babel fees, even though I tried to address them. No tests were performed.
This draft needs to be extended by some form of communication between individual recipient forms (likely just a parent component passing correctly synchronized props). This is needed so that if there are some assets selected for a recipient
A, then these assets are not displayed as fully available for recipientB(available balances are decreased appropriately).Extract recipient form containing
address and assets into a separate
component.
Keep track of a list of recipients
in SendView.
Extend P2P transaction building such
that it takes a list of receivers
instead of just a single one.
Successfully sent 2-recipient transaction.