Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed contractId and added made contracts required, signAndSendTran… #847

Open
wants to merge 6 commits into
base: SQC-540/add-signin-multi
Choose a base branch
from

Conversation

amirsaran3
Copy link
Collaborator

@amirsaran3 amirsaran3 commented Jul 3, 2023

Description

This PR is an extension of #811. Addressing comments of Daryl on mentioned PR.

Breaking changes:

  • Removed contractId from setupModal params
  • contracts param in setupModal is now required
  • receiverId param in signAndSendTransaction is now required since we can't assume a default contract since we can have multiple

TODO:

  • Since none of the wallets support the signInMulti method right now we can't test it correctly. I am not sure how will the pending state act after these changes (for browser wallets).

Questions:

  • signInMulti method with one contract in contracts param list is same as calling signIn method? Any notable differences?
  • Regarding this comment: feat: Add signInMulti method #811 (comment). If user first signs in using two contracts and then one of them expires. He then only wants to re-sign in to the expired one and the other one is still signed in. How will the UI flow work for this interaction? Since the user is signed in they will not see a prompt to sign in again.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@amirsaran3 amirsaran3 self-assigned this Jul 3, 2023
@amirsaran3 amirsaran3 mentioned this pull request Jul 5, 2023
14 tasks
@AZbang
Copy link
Contributor

AZbang commented Feb 12, 2024

@amirsaran3 when it will be merged?

Copy link

@dinhthuybg dinhthuybg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git stash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🥶
Development

Successfully merging this pull request may close these issues.

None yet

4 participants