Removed contractId and added made contracts required, signAndSendTran… #847
+170
−184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an extension of #811. Addressing comments of Daryl on mentioned PR.
Breaking changes:
contractId
fromsetupModal
paramscontracts
param insetupModal
is now requiredreceiverId
param insignAndSendTransaction
is now required since we can't assume a default contract since we can have multipleTODO:
signInMulti
method right now we can't test it correctly. I am not sure how will the pending state act after these changes (for browser wallets).Questions:
signInMulti
method with one contract incontracts
param list is same as callingsignIn
method? Any notable differences?signInMulti
method #811 (comment). If user first signs in using two contracts and then one of them expires. He then only wants to re-sign in to the expired one and the other one is still signed in. How will the UI flow work for this interaction? Since the user is signed in they will not see a prompt to sign in again.Checklist:
Type of change.