Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently more of a proof of concept to get some feedback on whether
this is a horrible idea, or somewhat reasonable.
I was mostly interested if this is possible at all and Justin mentioned using
b:
elsewhere, which afaik has some vimscript marshalling limitations for sometypes(?) and you cannot keep state completely hidden as implementation detail.
I'm also not yet sure if this can cover most cases. If there's positive feedback I'd try and convert some more spots, otherwise 馃毊
There are a few modules, each of which is managing state per buffer and
duplicating logic like cleanup.
Properly cleaning up can be tricky - see:
f32fd19
This introduces a
Buflocal
inspired by thread-local storage:https://en.wikipedia.org/wiki/Thread-local_storage
The
Buflocal
can be used to access state for a buffer, which getscleaned up if the buffer is deleted.
(Although the name here may be a bit misleading - as the buffer number is parameterized and you can get the state of other buffers, not just current. )