-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up DEB package dependencies. #17680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dpkg is an implicit dependency for all DEB packages by virtue of them being DEB packages, and we do not support any platforms that have an old enough version to be an issue, so we don’t need a versioned dependency on it either, so simply drop the explicit dependency on dpkg. - We also don’t support any platforms that ship an old enough version of libcap2-bin to cause us problems, so remove the version constraint on that as well. - The lsb-base predepend is only needed if the user is using a non-systemd init system. We don’t fully support this setup with our native packages, and it’s a non-default configuration for Debian and completely unsupported on Ubuntu, so it’s safe to assume that the user knows what they are doing if they need it and not explicitly require this. - The apps plugin was missed in netdata#17584, so fix it’s conflicts line here. - The chartsd plugin _requires_ bash to function correctly, so actually depend on it instead of recommending it (this will be a no-op on a vast majority of systems, but is still useful insurance against users doing stupid things). - The CUPS and FreeIPMI plugins both pull in all the things they actually need via automatic dependency generation, so there is no reason for us to pull in full installs of CUPS or FreeIPMI as dependencies. - Everything in the Go plugin that was using `sudo` has been converted to use `ndsudo` instead, so we don’t need to ask for `sudo` at all for it anymore. - The Python plguin _requires_ Python to function correctly, so actually depend on it instead of recommending it.
github-actions
bot
added
the
area/packaging
Packaging and operating systems support
label
May 16, 2024
vkalintiris
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages should also be inspected manually to confirm that the dependencies are correctly listed in the control files.
They should also be installed in a clean debian image.
lechgu
pushed a commit
to SaladTechnologies/netdata
that referenced
this pull request
May 23, 2024
* Clean up DEB package dependencies. - dpkg is an implicit dependency for all DEB packages by virtue of them being DEB packages, and we do not support any platforms that have an old enough version to be an issue, so we don’t need a versioned dependency on it either, so simply drop the explicit dependency on dpkg. - We also don’t support any platforms that ship an old enough version of libcap2-bin to cause us problems, so remove the version constraint on that as well. - The lsb-base predepend is only needed if the user is using a non-systemd init system. We don’t fully support this setup with our native packages, and it’s a non-default configuration for Debian and completely unsupported on Ubuntu, so it’s safe to assume that the user knows what they are doing if they need it and not explicitly require this. - The apps plugin was missed in netdata#17584, so fix it’s conflicts line here. - The chartsd plugin _requires_ bash to function correctly, so actually depend on it instead of recommending it (this will be a no-op on a vast majority of systems, but is still useful insurance against users doing stupid things). - The CUPS and FreeIPMI plugins both pull in all the things they actually need via automatic dependency generation, so there is no reason for us to pull in full installs of CUPS or FreeIPMI as dependencies. - Everything in the Go plugin that was using `sudo` has been converted to use `ndsudo` instead, so we don’t need to ask for `sudo` at all for it anymore. - The Python plguin _requires_ Python to function correctly, so actually depend on it instead of recommending it. * Fix typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Preliminary testing involves confirming that CI passes on this PR.
The packages should also be inspected manually to confirm that the dependencies are correctly listed in the control files.