Fix GH-746 - Loading config files order with APP_INSTANCE #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the loading order when having different file extensions and working with APP_INSTANCE as well.
Instead of doing a
forEach
on basenames and extensions, then adding theAPP_INSTANCE
, the filename using theAPP_INSTANCE
is defined before going through all extensions, so that it is loaded after all extensions without the APP_INSTANCE being defined.Did a console.log (that I removed) for the
allowedFiles
object when running the added test to show the difference:Before the fix:
After the fix: