Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import ETH keys #1535

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: import ETH keys #1535

wants to merge 1 commit into from

Conversation

prybalko
Copy link
Contributor

Purpose

Fixes & improvements for #1429.

Develoer notes

Flow looks like this:

  1. user scans the QR code, UI gets ExportAddrsContainer data structure with raw data.
  2. call get_derivations_preview with given ExportAddrsContainer and all available seeds. Get SeedKeysPreviewSummary with with separated importable_keys, already_existing_keys and non_importable_keys fields.
  3. call import_derivations with the same SeedKeysPreviewSummary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krodak krodak Awaiting requested review from krodak krodak will be requested when the pull request is marked ready for review krodak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prybalko