chore(repo): ensure changes to vite plugin are handled correctly #23578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Updating the vite plugin and the config it produces should correctly fail where needed.
Currently,
@nx/vite
depends on@nx/js
, however,@nx/js
also depends on@nx/vite
.There is a circular dependency there which is more difficult to circumvent.
Expected Behavior
To avoid circular dependency issues, move the tests that test the output of
vite.config.ts
to the@nx/vite:configuration
specs from the@nx/js:library
specs.Related Issue(s)
Fixes #