Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind 0.106.0 protocol chages to Cockatrice hardfork #3448

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

AnnaShaleva
Copy link
Member

Close #3440.

Port a part of neo-project/neo#3210.
A part of #3440.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
A part of #3440.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
It will be built properly in #3447.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
A part of #3440.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.13%. Comparing base (2d4993a) to head (c30e7ec).

Files Patch % Lines
pkg/core/native/crypto.go 66.66% 4 Missing and 2 partials ⚠️
pkg/core/interop/context.go 75.00% 1 Missing and 1 partial ⚠️
pkg/core/native/native_nep17.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3448   +/-   ##
=======================================
  Coverage   86.12%   86.13%           
=======================================
  Files         331      331           
  Lines       38442    38468   +26     
=======================================
+ Hits        33110    33135   +25     
  Misses       3804     3804           
- Partials     1528     1529    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 6a58337 into master May 20, 2024
20 of 21 checks passed
@roman-khimov roman-khimov deleted the migrate-to-hf branch May 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind 3.7 protocol changes to Cockatrice
2 participants