-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): namespace global variables for multi-app support #27263
Open
nicolaspayot
wants to merge
9
commits into
nuxt:main
Choose a base branch
from
nicolaspayot:feat/nuxt/multi-app-global-vars
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(nuxt): namespace global variables for multi-app support #27263
nicolaspayot
wants to merge
9
commits into
nuxt:main
from
nicolaspayot:feat/nuxt/multi-app-global-vars
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
nicolaspayot
changed the title
Feat/nuxt/multi app global vars
feat(nuxt): namespace global variables for multi-app support
May 17, 2024
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
May 18, 2024 20:21
f30a78c
to
b2ff8da
Compare
manniL
reviewed
May 19, 2024
@@ -50,6 +50,7 @@ export default defineNuxtPlugin({ | |||
} | |||
Object.assign(nuxtApp.payload, await nuxtApp.runWithContext(getNuxtClientPayload)) | |||
// For backwards compatibility - TODO: remove later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still wondering if we have to set the payload here / why it was marked for compat only?
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
May 22, 2024 07:39
b2ff8da
to
2c3f046
Compare
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
June 3, 2024 15:31
404be61
to
f2a86d2
Compare
nicolaspayot
force-pushed
the
feat/nuxt/multi-app-global-vars
branch
from
June 10, 2024 07:16
f2a86d2
to
4dee10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
2nd task of #21635. Also linked to #25336 although it doesn't completely remove
window.__NUXT__
.📚 Description
This PR updates
window.__NUXT__
global variable to handle multi-app payloads and config by storing the data under theirappId
.Before:
After:
It also replaces scripts global IDs
__NUXT_DATA__
and__NUXT_LOGS__
with data attributes:Before:
After:
This will eventually allows the use of multiple Nuxt applications on a same page.
📝 To do:
future
/experimental
flagwindow.__NUXT__
update innuxt/test-utils
. See feat: add multi-app support for global var__NUXT__
test-utils#858