Language-based object detectors (GLIP, Grounding DINO) support for MMDetection #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing PR @AMauri996 ! 🔥 🚀 Can you also include a quickstart notebook as in other integrations so that users know how to use it? You can take a look at other notebook files here: https://github.com/obss/sahi/tree/main/demo |
|
@AMauri996 can you fix the styling? |
|
Is there something missing? Happy to jump and help in case it is needed |
|
@fcakyon I fixed the styling, it should be good now |
|
@AMauri996 thanks a lot! Please fix the nltk based failure in the continuous integration tests @AMauri996 @RobertoPalomares 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! I've added support of language-based object detectors (GLIP, Grounding DINO) from the latest release of MMdetection which require a text prompt in order to work. I've also included a test and download utils.
Users can provide a custom text prompt using
--textargument. If none is provided the class names are used as the text prompt.