Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce wrong link flag if pkg-config not in $PATH #10353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anmonteiro
Copy link
Collaborator

this was originally spotted in ygrek/ocaml-zstd#9 when I couldn't understand why zstd wouldn't build.

  • in this test, we have (external_library_name libexample) and (build_flags_resolver pkg_config), however the pkg-config executable is not in $PATH
  • dune seems to derive the linker flags from external_library_name, which is a bit weird with this failure mode. Is that expected?
    • should this rather be an error that Dune failed to resolve pkg-config?

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
13 | (functor Function_description))
14 | (generated_entry_point C)))
ld: library not found for -llibexample
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-16 is likely to be specific to my system

@rgrinberg
Copy link
Member

should this rather be an error that Dune failed to resolve pkg-config?

Sure that would be fine. Would there be another way of specifying a default in case a package isn't found in pkg-config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants