Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: repro #10301 #10371

Merged

Conversation

anmonteiro
Copy link
Collaborator

reproes #10301

@anmonteiro
Copy link
Collaborator Author

anmonteiro commented Apr 3, 2024

at least for the ocamllex case it's easy to see why the target is expected to be in the same dir as the dune file:

let dst = name ^ ".ml" in
{ targets =
(* CR-someday aalekseyev: want to use [multiplicity = One] here, but
can't because this is might get parsed with old dune syntax where
[multiplicity = One] is not supported. *)
Static { targets = [ S.make_text loc dst, File ]; multiplicity = Multiple }

@anmonteiro
Copy link
Collaborator Author

and for menhir:

let targets m ~cmly =
let base = [ m ^ ".ml"; m ^ ".mli" ] in
List.map ~f:(Path.Build.relative dir) (if cmly then (m ^ ".cmly") :: base else base)
;;

Copy link
Collaborator

@emillon emillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the repro. 2 remarks:

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/repro-menhir-include-subdirs branch from 69106cc to 7b5df23 Compare April 28, 2024 21:52
@anmonteiro
Copy link
Collaborator Author

@emillon changed this to be just about menhir, and renamed the test case to point to #10301.

@anmonteiro anmonteiro changed the title test: repro include_subdirs + menhir / ocamllex test: repro #10301 Apr 28, 2024
@anmonteiro
Copy link
Collaborator Author

ping @emillon

@anmonteiro anmonteiro enabled auto-merge (squash) May 25, 2024 21:10
@anmonteiro anmonteiro merged commit 6b60332 into ocaml:main May 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants