enable exec + watch tests with timeout #10384
Open
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corentin Leruth <corentin.leruth@gmail.com>
Signed-off-by: Corentin Leruth <corentin.leruth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exec-watchtests have been disabled in #7138 due to flakiness. This is a bit unfortunate, as these tests are useful for preventing regressions.What I suggest in this PR is to add a
timeoutto thewait-for-file.shscript. So after e.g.2 secondsthe script will exit with an error if the file does not exist. This should prevent a test from hanging forever.See for example
b705448(#10384), which is the result I got when I ran the tests on my MacOS machine. It helped me find the reason why the test was hanging forever (sed + symlink issue) and allowed me to fix it