Add repro for exec watch mode bug #10391
Open
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
reviewed
Apr 5, 2024
test/blackbox-tests/test-cases/exec-watch/exec-watch-multi-levels.t/bin/main.ml
Outdated
Show resolved
Hide resolved
gridbugs
force-pushed
the
repro-exec-watch-relative-path-bug
branch
2 times, most recently
from
798cf65
to
fd3e25a
Compare
This adds a test reproducing a bug with exec watch mode where dune is unable to find an executable if it's specified with a relative path when the user's cwd is not the project root. Note that the watch mode tests are disabled by default as they are flakey. Signed-off-by: Corentin Leruth <corentin.leruth@gmail.com>
gridbugs
force-pushed
the
repro-exec-watch-relative-path-bug
branch
from
fd3e25a
to
22b7f14
Compare
|
@emillon I think this slipped through the cracks. Think it's good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test reproducing a bug with exec watch mode where dune is unable to find an executable if it's specified with a relative path when the user's cwd is not the project root.
Note that the watch mode tests are disabled by default as they are flakey.