Automatically lock on build if there is no lock dir
#10487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more of an exploration of the toolchains work as it would automatically lock whenever any user that does not yet have a lock file calls `dune build`. For an inclusion in the main dune this would need to be configurable on... something. The right criterion is up for discussion. Signed-off-by: Marek Kubica <marek@tarides.com>
gridbugs
approved these changes
May 8, 2024
There was a problem hiding this comment.
This is a good start but I think we also need to handle the case where the dependencies in dune-project are updated such that they no longer match what's in the lockdir. It should never be necessary to explicitly create a lockdir.
Happy for that to come in a later change though.
emillon
reviewed
May 16, 2024
| @@ -47,7 +47,21 @@ let run_build_system ~common ~request = | |||
| Cached_digest.invalidate_cached_timestamps (); | |||
| let* setup = Import.Main.setup () in | |||
| let request = | |||
| Action_builder.bind (Action_builder.of_memo setup) ~f:(fun setup -> request setup) | |||
| let open Action_builder.O in | |||
| let autolock = | |||
There was a problem hiding this comment.
to ease merging back into main, what do you think about inserting a seam here?
something like:
let use_autolock = true
...
let request =
if use_autolock then
... this PR ...
else
...original code
...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of an exploration of the toolchains work as it would automatically lock whenever any user that does not yet have a lock file calls
dune build.For an inclusion in the main dune this would need to be configurable on... something. The right criterion is up for discussion.