scheduler: remove status field
#10520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accumulation of the invalidation is orthogonal to what the build status is. Regardless of how the build progresses, we should always continually combine new build input change into the current invalidation, and we should only set the invalidation to empty when we also call Memo.reset with the current invalidation. At the same time, it also makes sense to cleanup the handling of the "build_input_change" ivar. There is no need for it to be an option that is initialized on-demand, since it is easy and cheap to just create an initial ivar. In addition, we shouldn't care what the current build status is when waiting for a file to change. (I suspect that some of the reason for the complication is due to the "--react-to-insignificant-file changes" flag that no longer exists. This patch doesn't claim to fix any bugs; it's just intended as a code cleanup. Signed-Off-By: Philip White <code@trailingwhite.space>
added 2 commits
May 13, 2024 08:38
It doesn't need to be there because we already have `t.cancel`. Signed-Off-By: Philip White <code@trailingwhite.space>
Previous changes have moved all the useful information from the status field into other fields, such as `cancel` and `invalidation`, so now we can get rid of the field altogether. Signed-Off-By: Philip White <code@trailingwhite.space>
|
I included the commits in #10519, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #10519
Previous changes have moved all the useful information from the status field into other fields, such as
cancelandinvalidation, so now we can get rid of the field altogether.