Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(boot): remove unused variables #10527

Merged
merged 2 commits into from
May 15, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented May 14, 2024

Some options are interpreted by bootstrap.ml, other ones by duneboot.ml. They need to be parsed, but can be ignored instead of setting a dummy reference.

Some options are interpreted by `bootstrap.ml`, other ones by
`duneboot.ml`. They need to be parsed, but can be ignored instead of
setting a dummy reference.

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon requested a review from rgrinberg May 14, 2024 11:46
@emillon emillon merged commit 5904a00 into ocaml:main May 15, 2024
26 of 28 checks passed
@emillon emillon deleted the refactor-boot-variables branch May 15, 2024 07:41
MA0010 pushed a commit to MA0010/dune that referenced this pull request Jun 5, 2024
Some options are interpreted by `bootstrap.ml`, other ones by
`duneboot.ml`. They need to be parsed, but can be ignored instead of
setting a dummy reference.

Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants