Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored label comparison #13113

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Conversation

samsa1
Copy link
Contributor

@samsa1 samsa1 commented Apr 23, 2024

Factored together the code to compare labels during unification.

This is just reducing code duplication and does not have any impact on the user. I think this might not require a Changes entry.

This refactor was motivated by modular explicit that might require more label comparison.

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but I don't think that in_pattern_mode should be an optional parameter: if you forget to use it when you should, the compiler is unsound (in a very very small corner case). Let's make it mandatory.

@gasche gasche added the typing label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants