Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accepted this PR adds the
TCP_QUICKACK
socket option.TCP_QUICKACK
can be of use on low latency networks where a socket buffer may not fill up in the hard coded 200ms window. SettingTCP_QUICKACK
will cause acknowledgements to be sent immediately.PS. This PR was heavily inspired by #9869 and I'm not convinced I did everything correctly. For example it is not clear to me why the
TCP_NODELAY
macro exists insockopt_unix.c
but not insockopt_win32.c
and because I don't understand I opted to not add the macro tosockopt_win32.c
.EDIT: The build failed without the macro in
sockopt_win32.c
so I ended up adding it after all.