Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ime/#2781): Correctly position IME popup #3546

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

fix(ime/#2781): Correctly position IME popup #3546

wants to merge 19 commits into from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented May 14, 2021 •
edited

WIP to fix #2781

TODO:

  • Gate debug rendering with a configuration setting
  • Use correct font family / size for composition text depending on environment
  • Fix IME input position in text inputs
  • Fix multiple characters entered in text input
  • Fix positioning in terminal
  • Block other input when IME is active and composing
  • Set up subscription for composition events
  • Render composition text
  • Render composition text with underline
  • Test with ibus on Linux
  • Test on MacOS
  • Test on Windows
  • Add manual test cases

@bryphe bryphe added the WIP label May 14, 2021
@bryphe bryphe changed the title fix(ime/#2781): Correctly position IME popup fix(ime/#2781): Correctly position of IME popup May 15, 2021
@bryphe bryphe changed the title fix(ime/#2781): Correctly position of IME popup fix(ime/#2781): Correctly position IME popup May 15, 2021
@bryphe bryphe mentioned this pull request May 17, 2021
Merged
bryphe added a commit that referenced this pull request May 18, 2021
@bryphe
refactor(terminal): Bring in reason-vterm/revery-terminal (#3555)
fa280af 
This brings in some of the terminal code & tests from https://github.com/revery-ui/revery-terminal to make it easier to iterate on the terminal functionality.

Needed for #3546 to properly position IME in integrated terminal
@zbaylin zbaylin mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location incorrect with chinese IME
1 participant
@bryphe