Add transfer_all to Currencies
#379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
requested changes
Feb 22, 2021
| ) -> DispatchResultWithPostInfo { | ||
| let from = ensure_signed(origin)?; | ||
| let to = T::Lookup::lookup(dest)?; | ||
| let balance = <Self as MultiCurrency<T::AccountId>>::free_balance(currency_id, &from); |
There was a problem hiding this comment.
Do you mean apply this for transfer_all in token module as we only define it in orml-tokens
|
I think the best way is add Also update the tests to check the case when user have some locked token. |
Make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
transfer_allto currenciesNot fully understand the requirements for # 375, for
tokensmodule there has already havetransfer_allfunction.Further steps:
transfer_all_non_native_currency