Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct/cg/fs: fix setting rt_period vs rt_runtime #4258

Merged
merged 1 commit into from
May 21, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Apr 25, 2024

The problem/fix is similar to one in #3084/#3090.

A test case (by @ls-ggg) is copied from #4235.

Fixes: #4094.
Closes: #4235.

@kolyshkin kolyshkin changed the title tests/int: add tests for rt_period vs rt_runtime libct/cg/fs: fix setting rt_period vs rt_runtime Apr 25, 2024
@kolyshkin kolyshkin marked this pull request as ready for review April 26, 2024 01:26
@kolyshkin kolyshkin added the backport/todo/1.1 A PR in main branch which needs to be backported to release-1.1 label Apr 26, 2024
@lifubang
Copy link
Member

@ls-ggg PTAL

@ls-ggg
Copy link
Contributor

ls-ggg commented Apr 28, 2024

@lifubang LGTM

@kolyshkin
Copy link
Contributor Author

@AkihiroSuda PTAL 🙏🏻

The issue is the same as in commit 1b2adcf but for RT scheduler;
the fix is also the same.

Test case by ls-ggg.

Co-authored-by: ls-ggg <335814617@qq.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

This needs to be backported to 1.1 and I want this to be included into 1.1.13, but before doing a backport this needs to be merged; so PTAL @opencontainers/runc-maintainers

@lifubang lifubang requested a review from cyphar May 21, 2024 00:52
@AkihiroSuda AkihiroSuda merged commit 68564ee into opencontainers:main May 21, 2024
40 checks passed
@kolyshkin
Copy link
Contributor Author

1.1 backport: #4284

@kolyshkin kolyshkin added backport/done/1.1 A PR in main branch which was backported to release-1.1 and removed backport/todo/1.1 A PR in main branch which needs to be backported to release-1.1 labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cgroupv1 backport/done/1.1 A PR in main branch which was backported to release-1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When runc updates the values ​​of cpu-rt-period and cpu-rt-runtime synchronously, an error occurs.
4 participants