-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A570218846721951 health check #86
base: eauctions-sandbox
Are you sure you want to change the base?
A570218846721951 health check #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А де тести на init_services
та check_auction_workers
?
logging.addLevelName(25, 'CHECK') | ||
|
||
|
||
def check(self, msg, exc=None, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А docstring
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarsanich, додав.
worker_exceptions = check_auction_workers(self.config['main']) | ||
if worker_exceptions: | ||
exceptions.extend(worker_exceptions) | ||
if exceptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тобто з всих ти полюбому будеш raise робити першого ? І Ерори , якщо вони будуть, то вони будуть в порядку CouchDB, Scheduler, WebApp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarsanich, так, в тому порядку ініціалізації, який був до цього.
AuctionsChronograph(config).run() | ||
chronograph = AuctionsChronograph(config) | ||
if params.check: | ||
exit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys.exit()
?
* Replace exit() call wit sys.exit()
This change is