-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test taking ownership of a field #28740
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Force: true, | ||
}) | ||
postBytes, _ = json.Marshal(postApply.Object) | ||
framework.Logf("after trying to replace the field\n%v", string(postBytes)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"apiVersion": "testing.openshift.io/v1",
"kind": "SSAWithSet",
"metadata": {
"creationTimestamp": "2024-04-24T21:14:18Z",
"generation": 2,
"managedFields": [
{
"apiVersion": "testing.openshift.io/v1",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:spec": {
"f:setList": {
"v:\"first\"": {},
"v:\"second\"": {}
},
"f:unrelatedField": {}
}
},
"manager": "creator",
"operation": "Apply",
"time": "2024-04-24T21:14:18Z"
},
{
"apiVersion": "testing.openshift.io/v1",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:spec": {
"f:setList": {
"v:\"apple\"": {},
"v:\"banana\"": {}
}
}
},
"manager": "new-owner",
"operation": "Apply",
"time": "2024-04-24T21:14:18Z"
}
],
"name": "foo",
"resourceVersion": "65295",
"uid": "27acfc2e-7452-4722-b043-5e1a86cab35f"
},
"spec": {
"setList": [
"first",
"second",
"apple",
"banana"
],
"unrelatedField": "keep-original-owner"
}
}
alright, the combination of shared ownership and set sharing and ownership transfer means that there is no clear way to transfer ownership of set lists. We'll need to decide whether to
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wild interaction with SSA and |
demonstrate how to take ownership of a set-list.
/hold