-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-14373: Update kube vendor to fix HPA test flake #28812
Conversation
Generated with: hack/update-kube-vendor.sh release-4.14 One of the HPA test cases was flaking, I fixed it in openshift/kubernetes but we need to re-vendor here to pick up the fix.
@jkyros: This pull request references Jira Issue OCPBUGS-14373, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jkyros The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jkyros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
So:
I would have expected it to complain about
I'm also apparently faling |
Looks like #28806 just did what I was trying to do, so I'm closing this. Thanks Maciej! |
@jkyros: This pull request references Jira Issue OCPBUGS-14373. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
I fixed an HPA test flake over here in openshift/kubernetes#1958, but my understanding is the fix won't be reflected in the periodics until we have it in vendor here.
Reading the README here in
openshift/origin
it seemed like in order to make that happen, I was supposed to do:So that's what I did. The deps do contain the fix I was looking for, so it looks like it worked, but it is entirely possible I am still an ignoramus and missing something 馃槃
Fixes: OCPBUGS-14373