New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back compatibility with torch #1904

Merged

thewhaleking merged 20 commits into staging from feature/add-back-compatibility-with-torch/thewhaleking

May 21, 2024

Contributor

thewhaleking commented May 20, 2024 •

edited

Adds back compatibility with torch, invoked by passing the USE_TORCH env var.

Fixes #1897

thewhaleking added 2 commits

May 20, 2024 15:08


          [WIP] Backporting the torch functionality

4e9369b


          [WIP] Black format.

346c189

gus-opentensor reviewed

View reviewed changes

bittensor/chain_data.py Outdated Show resolved Hide resolved

gus-opentensor reviewed

View reviewed changes

bittensor/chain_data.py Outdated Show resolved Hide resolved

thewhaleking added 11 commits

May 20, 2024 18:25


          [WIP] check-in

d1311f6


          [WIP] Check-in

1f2989e


          [WIP] Check-in

81f2a42


          [WIP] Check-in

0abdc88


          [WIP] Fixed dendrite Mixin

a8a48ff


          [WIP] Tests

bdb8ec6


          [WIP] Fixed tests.

e54301f


          [WIP] Dendrite fix for mypy redeclaration.

e12fc6b


          [WIP] updates

7fa6746


          Fixed tests and mypy and black.

e59b782


          Flake tests

dbc5701

thewhaleking requested a review from a team

May 21, 2024 17:55

thewhaleking marked this pull request as ready for review

May 21, 2024 17:55


          Merge branch 'staging' into feature/add-back-compatibility-with-torch…

…/thewhaleking

Collaborator

gus-opentensor commented May 21, 2024

Looks great!

Suggestion: add a file .example.env with USE_TORCH= and add a comment to indicate what have it set to 0 or 1 does.

RomanCh-OT reviewed

View reviewed changes

bittensor/utils/__init__.py Show resolved Hide resolved

RomanCh-OT reviewed

View reviewed changes

bittensor/metagraph.py Outdated Show resolved Hide resolved

RomanCh-OT reviewed

View reviewed changes

bittensor/metagraph.py Outdated Show resolved Hide resolved

RomanCh-OT reviewed

View reviewed changes

bittensor/dendrite.py Outdated Show resolved Hide resolved

RomanCh-OT reviewed

View reviewed changes

bittensor/commands/root.py Outdated Show resolved Hide resolved

thewhaleking added 2 commits

May 21, 2024 21:17


          Roman-requested changes, as well as changing use_torch to a general b…

27f1048

…ool function rather than selecting individually from the `os.environ` every time.


          Flake8 and Black

02968f8

RomanCh-OT approved these changes

View reviewed changes

Contributor

RomanCh-OT left a comment

LGTM

gus-opentensor approved these changes

View reviewed changes

thewhaleking and others added 2 commits

May 21, 2024 21:56


          Flake8 and README update.

573fda5


          Merge branch 'staging' into feature/add-back-compatibility-with-torch…

cf01404

…/thewhaleking

thewhaleking added 2 commits

May 21, 2024 22:26


          Updated error msg for torch, added error msg for running the faucet c…

…ommand without torch.


          Updated tests to conform to the correct type structure of the method.

56855fb

thewhaleking merged commit 9653271 into staging

11 checks passed

mjurbanski-reef mentioned this pull request

fix PoW and other functions not working with USE_TORCH=0 despite torch being available #1917

Merged

This was referenced May 24, 2024

Added tests to cover all compatibility layer cases. #1937

Merged

replace torch with numpy #1869

Open

ibraheem-opentensor mentioned this pull request

Release/7.0.0 #1899

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment