Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports used in member props #9710

Draft
wants to merge 2 commits into
base: v2
Choose a base branch
from
Draft

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented May 9, 2024

Previously, it didn't continue visiting the property part of member expressions, thus imports used in there were ignored (and then incorrectly excluded from the bundle).

In this case, the import only had the import foo1 but not foo2 registered. Then foo2 became undefined at runtime

import { foo1, foo2 } from "../test/b.js";

var _a = {};
_a[foo2] = "foo";
console.log(foo1, _a);

Closes #9275

TODO

  • This broke something else in the transformer

@mischnic mischnic requested a review from devongovett May 9, 2024 11:51
@mischnic mischnic marked this pull request as draft May 9, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'top')
2 participants