Harvester metrics wrong when the host name/ip is repeated #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple harvesters have the same domain name or IP (when behind a router) we only get the last harvester in the metric, because we keep replacing the earlier ones. By appending the node_id to the host they become unique and correctly reported. As a bonus those node IDs are the same ones identifying the harvesters in flexpool so you can track which is which.
philippnormann
force-pushed
the
main
branch
6 times, most recently
from
7d4f013
to
8f80799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple harvesters have the same domain name or IP (when behind a router) we only get the last harvester in the metric, because we keep replacing the earlier ones.
By appending the node_id to the host they become unique and correctly reported.
As a bonus those node IDs are the same ones identifying the harvesters in flexpool so you can track which is which.