HTTPS proxy support (Second attempt) #3691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnel usage)
GCS server does not handle requests with port, and simply report an
error:
<?xml version="1.0"?>
<?xml version='1.0' encoding='UTF-8'?>
<Error>
<Code>InvalidURI</Code>
<Message>Couldn't parse the specified URI.</Message>
<Details>Invalid URL: storage.googleapis.com:443/...</Details>
</Error>
Removing the port fixes the issue. Note that there is port in the Host
header anyway.
Note, this is a problem only for proxy in a tunnel mode, since only it
sends such requests, other sends requests directly via HTTP methods.
Closed
aleks-f
reviewed
Jul 18, 2022
There was a problem hiding this comment.
proxy tests still failing on all platforms
There were 3 errors:
1: N7CppUnit10TestCallerI21HTTPClientSessionTestEE.testProxy
"N4Poco3Net18NoMessageExceptionE:
No message received"
in "<unknown>", line -1
2: N7CppUnit10TestCallerI21HTTPClientSessionTestEE.testProxyAuth
"N4Poco3Net18NoMessageExceptionE:
No message received"
in "<unknown>", line -1
3: N7CppUnit10TestCallerI21HTTPStreamFactoryTestEE.testProxy
"N4Poco3Net18NoMessageExceptionE:
No message received"
in "<unknown>", line -1
|
@Jokser do you plan to work on this or should I close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased work on #3040
#3035
Added possibility to connect to HTTPS proxy.
Not all proxies support CONNECT requests, so it's possible to send a request directly to HTTPS proxy without CONNECT requests. This behavior is controlled by the proxy tunnel option which is 'true' by default for backward-compatibility.
In the case of HTTP endpoint and HTTP proxy, there is no tunneling despite the tunnel option being true by default. This was done also for backward-compatibility.
I also included the following fix ClickHouse#63
These changes are battled-tested in ClickHouse project.