-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using native sendfile from OS for HttpServer #4351
Open
bas524
wants to merge
9
commits into
pocoproject:main
Choose a base branch
from
bas524:httpserver.sendfile
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add option POCO_USE_SENDFILE_FOR_HTTPSERVER, default - OFF add test for HttpServer - testFile add define fro Config.h POCO_USE_SENDFILE_FOR_HTTPSERVER
teksturi
reviewed
Dec 16, 2023
teksturi
reviewed
Dec 16, 2023
teksturi
reviewed
Dec 16, 2023
teksturi
reviewed
Dec 17, 2023
detected macro POCO_HAVE_SENDFILE replace types for sendFile with platform depended wrap possibility of using sendFile with macro, if sendFile doesn't exist in OS, then all methods don't exist
teksturi
reviewed
Dec 17, 2023
teksturi
reviewed
Dec 17, 2023
teksturi
reviewed
Dec 17, 2023
Hi, @obiltschnig ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by #3368 and continuation of #4007
If OS has native implementation of sendfile function then it will be used (only for cmake projects).
Other projects (make and vcxporj) you can uncomment define
POCO_HAVE_SENDFILE
inPoco/Config.h
Note for emscripten sendfile will throw NotImplemented exception, because emscripten-core/emscripten#16234
Simple proof that this optimization is useful
Test without optimization
Test with optimization
15% vs 5%