Allow set enum as json value (#4363) #4434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix issue #4341 add testEnum if you set enum as json value then it will be cast to int * add behavour for enum into VarHolderImpl add tests for enum classes with differnent underline integral types * replace static_cast with convertTo* methods, they can chaeck types and limits * fix missing types for convert methods * fix code style add testEnumType to the VarTest.cpp, extract() works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue 1.12.4 version Json set enum value failed #4341 add testEnum
if you set enum as json value then it will be cast to int
add behavior for enum into VarHolderImpl add tests for enum classes with different underline integral types
replace static_cast with convertTo* methods, they can check types and limits
fix missing types for convert methods
fix code style add testEnumType to the VarTest.cpp, extract() works