Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coretime): add Overview page #10383

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

feat(coretime): add Overview page #10383

wants to merge 43 commits into from

Conversation

bee344
Copy link
Contributor

@bee344 bee344 commented Mar 22, 2024

Description

Adds the Overview page to the Coretime tab. This first step aims to add a Coretime tab to integrate its functionalities with PJS/APPS, with an Overview page that provides some relevant Summary information in a user-friendly manner.

Tasks for Coretime Chain

  • Add Summary.
  • Add Workload.
  • Add Workplan as a separate table.
  • Update Workload to improve readability.
  • Add filters to Workplan and Workload to filter by core and timeslice.
  • Modify appearance.

Tasks for Relay Chain

  • Add Summary including Spot Traffic, core usage.
  • Add Core Descriptors as table.
  • Add Core Schedules as table
Optional:
  • Modify appearance adding a timeline.

Regarding the appearance, I'm thinking on something simmilar to the Referenda page, since the amount of information for Workload and Workplan is substantial.
E.G. Image:

image

This is only as to reference the functionality of collapsing a table and adding a filter.

Part 1 of #10285

@bee344 bee344 marked this pull request as ready for review April 15, 2024 16:46
@bee344
Copy link
Contributor Author

bee344 commented Apr 15, 2024

A small sidenote: onDemandCoretimeAssigner wasn't included in the Overview since it isn't in use currently, and although we could make assumptions on how it would look liker, as evidenced with the key for coreDescriptors, sometimes stuff doesn't show up as it should. So I think it's better to wait until we have something to work with and then including it.

@TarikGul
Copy link
Member

After some discussion we decided to switch the logic into 2 pages.

pages-broker
pages-coretime

@TarikGul TarikGul mentioned this pull request May 7, 2024
4 tasks
@TarikGul
Copy link
Member

I think the core idea is there but there is some major cosmetic issues we need to fix before we release it:

  1. Usage should have a percentage attached to it. Next index is blank for me as well.
Screenshot 2024-06-10 at 7 16 47 PM
  1. The left and right divs here are should have the same vertical width. Also the border of where the 100% task is denoted has no bottom border which is should.
Screenshot 2024-06-10 at 7 17 39 PM
  1. When the string increases in task the div should not widen as below.
Screenshot 2024-06-10 at 7 19 04 PM

Currently I am not getting any info in the dropdowns.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few cosmetic things to change.

@bee344
Copy link
Contributor Author

bee344 commented Jun 11, 2024

  1. Usage should have a percentage attached to it. Next index is blank for me as well.

@TarikGul The info not showing is because of a missmatch between the pallet versions used by Rococo and Westend and the one used by Kusama (v1 vs v0), and that info not appearing in v0. I used Westend and Rococo for testing so I didn't catch that, my bad.

The usage percentage on the other hand, when you hover over the graph you can see what's the percentage assigned to that "assignment" (idle, task or pool). Since there can be 3 states at the same time, how do we choose which percentage we show? And if we show all three it gets messy. If you check on Rococo or Westend, you can see the graph has a different color assigned to each "assignment", and hovering over them you can see the percentage of cores dedicated to that "assignment". It's the way I found to have it look cleaner, but let me know if you still think we should change it.

imagen

I can't catch the hovering percentage box with the screencap, but you can see it by going there.

Edit: Added image for reference.
Edit2: comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants