Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BTreeMap and fix rpc optional #9911

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Support BTreeMap and fix rpc optional #9911

merged 9 commits into from
Jun 12, 2024
+173 −5

Conversation

Neopallium
Copy link
Contributor

Closes issue #1723

@TarikGul
Copy link
Member

@Neopallium I have this on my list to review, and will do it as soon as possible so we can get this in.

TarikGul
TarikGul requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks super solid Thanks so much for the PR! The BTreeMap Component is spot on, and the vector fix is awesome.

Just a small nit with the console, and a quick question about the rpc optional fix. Other than that it should be ready to go.

@TarikGul
Copy link
Member

Just needs a yarn lint

@Neopallium Neopallium force-pushed the support_btreemap_fix_rpc_optional branch from b478f4a to 24f3f99 Compare March 25, 2024 17:35
@Neopallium
Copy link
Contributor Author

lint applied.

@TarikGul TarikGul merged commit 7e58122 into polkadot-js:master Jun 12, 2024
5 checks passed
@TarikGul TarikGul mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Polkadot-js general project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neopallium @TarikGul