Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project updates (plus sentry DSN fix) #30

Merged
merged 12 commits into from
Apr 15, 2024
Merged

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Apr 15, 2024

Mainly to fix sentry failing due to osu.Game pulling a newer version which requires non-null DSN.

Failure: https://github.com/ppy/osu-queue-score-statistics/actions/runs/8680179864/job/23801813971?pr=257

2024-04-15 11 04 03@2x

@bdach
Copy link
Contributor

bdach commented Apr 15, 2024

There's a suspicious NRT-related warning:

1713164871

var redisItems = database.ListRightPop(QueueName, config.BatchSize);
// queue doesn't exist.
if (redisItems == null)
{
Thread.Sleep(config.TimeBetweenPolls);
continue;
}

and I'm actually not sure whether the annotation is wrong, or the xmldoc is, because they state contradictory things.

I reported this upstream (StackExchange/StackExchange.Redis#2697).

@bdach
Copy link
Contributor

bdach commented Apr 15, 2024

...right, .NET versions in workflows are gonna need bumping too (both of them).

@smoogipoo smoogipoo merged commit ca6f08d into ppy:master Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants